Recommended Fuel Pump?

[TurtleDesignTech]

My 1991 316i has never idled properly, cannot idle itself at start up and bogs down as soon as throttle is applied. I am yet to drive the car out on the road since I brought it a few months ago.

I noticed the fuel pump make a loud whirring noise outside the car and have decided to replace it in hope to fix this problem as well as "general maintenance".

I have already removed the fuel pump (took about 30 mins).

I have since had a look around on the interwebs for a replacement.

I found this on eBay - http://www.ebay.co.uk/itm/KEMSO-340LPH- ... Sw5dNWhODF KEMSO Fuel Pump for £25 as a full replacement kit.
Is this just Jap Crap?Or actually a good deal?

Should I just replace it with a OEM Bosh one or something else? Walbro? If so is there anywhere I can get a good deal on one?

Any other ideas to the idling problems if the fuel pump replacement doesn't fix it?[/b]

[pianist]

Did you check fuell pressure or TPS or ICV? Good thing in any case would be fuel filter change as it is a service item and should be changed as part of it when you buy a car and do a service to it

[Brianmoooore]

An E30 in tank fuel pump will make a loud whine when the commutator begins to wear out, so if that's what's happening, you need a new pump. I've no idea of the quality of the ebay pump you've found, but it's certainly cheap enough, so it might be worth a try. Pumps can also make a loud whine if the bottom of the tank is dented, and the pump is touching the bottom.
I doubt if a new pump will do anything for your problems though, since it will still produce adequate pressure and flow, especially at idle, until it starts to stall.

[pianist]

Check your timing marks just in case, it is easy to do and doesn't cost anything

[HairyScreech]

Beware of a lot of Walbro style pumps from Ebay, they are a little short and result in horrific fuel surge issues.
Need to pull mine out and go back to a stock pump and it surges with less than about 1/2 tank of fuel.

[TurtleDesignTech]

UPDATE:

I decided to put the fuel pump back in as I eliminated it a cause of my idling problem as the engine did rev so there was definitely fuel pressure.

Timing is all good as I changed the belt a week ago, so I have decided after some investigation that it was probably the ICV, as it sounds very similar to some videos on YouTube.

I got a shiny new stainless exhaust a couple of days ago too, which as drastically improved the idling to the point where I don't really want to dig the ICV out. The old exhaust was all coked up and the few holes it had in it must have significantly messed with the air flow.

I will probably get a new pump in the near future still. Thanks to Brianmoooore for explaining that it was the commutator that was wearing out.

Thanks to everyone for the help.